Add optional message to Option.getExn #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Apr 18, 2024
src/Core__Option.res
Outdated
| | None => | ||
| Core__Error.panic( | ||
| switch message { | ||
| | None => "Not found." |
There was a problem hiding this comment.
Looking at the implementation of panic, this means that by default an Error will be raised with the message "Panic! Not found." which sounds a bit weird to me.
Not sure what would be a better message, maybe something like
"Panic! Option.getExn called for None value"
?
There was a problem hiding this comment.
Yeah, better. Changing.
There was a problem hiding this comment.
What about using a custom exception? It could be in a different function though.
cknitt
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks the
expectstyle function from #57, now that we focus on uncurried mode only, and therefore can add trailing optional arguments with no issues.