-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime tests using examples from docstrings #210
Open
aspeddro
wants to merge
26
commits into
rescript-lang:main
Choose a base branch
from
aspeddro:doc-test-js-outuput
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
changed the title
PoC: Runtime tests using examples from docstrings
Runtime tests using examples from docstrings
Apr 8, 2024
Ready for review |
fhammerschmidt
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice work, some of the examples could be a bit more beginner-friendly but I know that is very hard to do without making them untestable.
I made a small improvement in two examples in the |
fhammerschmidt
approved these changes
Jun 6, 2024
@zth what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to add unit tests using docstrings. Currently the examples from docstrings have tests for compilation only.
bsc
emits the Js and passes the code tonode
using the--eval|-e
argument.TODO:
setIntervalFloat
Changes
assert_eq
functionsrc/Core__Global.resi
Array
from the test suite and moved it to docstrings.DocTest script
--ignore-runtime-tests
--ignore-runtime-tests 'RescriptCore.Array.toReversed,RescriptCore.Promise.withResolvers'
.Array.toReversed
andPromise.withResolvers
are not supported by Node