Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove changes to coverage file #4

Merged
merged 1 commit into from
May 2, 2015
Merged

remove changes to coverage file #4

merged 1 commit into from
May 2, 2015

Conversation

stevepeak
Copy link
Contributor

We can recognize the default output of go test when coverage is enabled. I'm not sure if there was a specific purpose behind the lines changed.

Checkout the codecov/example-go at .travis.yml

resal81 added a commit that referenced this pull request May 2, 2015
remove changes to coverage file
@resal81 resal81 merged commit 1ff82e3 into resal81:master May 2, 2015
@resal81
Copy link
Owner

resal81 commented May 2, 2015

Thanks for your help.

I still don't see the coverage report (https://codecov.io/github/resal81/molkit).

I had those lines to to create one combined coverage.txt in the root directory. I thought that it'd do the trick, as the Tavis log showed the combined file had been uploaded successfully.

@stevepeak
Copy link
Contributor Author

Let me play around with this. I'll be in touch shortly. Thanks for being patient!

@stevepeak
Copy link
Contributor Author

Ok. Found the problem. The uploader is grabbing the actual contents of scripts/coverage.sh and sending that to our server, which breaks. I'm going to patch the server to account for this issue.

I'll fire a couple tests off to make sure its working and then report back here. Thanks!

@stevepeak
Copy link
Contributor Author

Fixed! You can revert back to the original methods you had, before my PR. Thanks for hanging in there!

My test results: https://codecov.io/github/stevepeak/molkit?ref=c33a9172f4652df08f7ba1a5fd6881cff245539b

resal81 added a commit that referenced this pull request May 2, 2015
This reverts commit 1ff82e3, reversing
changes made to 08c106c.
@resal81
Copy link
Owner

resal81 commented May 2, 2015

Awesome. Now it's working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants