fix clippy::unwrap_used in re_viewer with Option::expect #8745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🚜 refactor
brody4hire
commented
Jan 22, 2025
brody4hire
commented
Jan 22, 2025
brody4hire
force-pushed
the
resolve-clippy-unwrap_used-in-re_viewer
branch
from
41931d1 to
e0d4ff3
Compare
brody4hire
commented
Jan 22, 2025
brody4hire
force-pushed
the
resolve-clippy-unwrap_used-in-re_viewer
branch
from
a719ec0 to
fd9e54a
Compare
brody4hire
commented
Jan 22, 2025
There was a problem hiding this comment.
@Wumpf I have shamelessly thrown away your cleanup work in favor of using .expect("... (internal error)") calls (I am assuming no offense will be taken). I think this should both reduce the number of lines in most cases and clarify the code a little better.
I think this should be ready now. Please do feel free to apply any other cleanup you think may be needed & be sure to add yourself as a co-author.
emilk
reviewed
Jan 24, 2025
crates/viewer/re_viewer/src/ui/welcome_screen/welcome_section.rs
Outdated
Show resolved
Hide resolved
brody4hire
force-pushed
the
resolve-clippy-unwrap_used-in-re_viewer
branch
from
a1df8c2 to
82a262c
Compare
brody4hire
commented
Jan 24, 2025
brody4hire
force-pushed
the
resolve-clippy-unwrap_used-in-re_viewer
branch
from
5e7c062 to
be85177
Compare
brody4hire
changed the title
brody4hire
changed the title
brody4hire
commented
Jan 30, 2025
brody4hire
force-pushed
the
resolve-clippy-unwrap_used-in-re_viewer
branch
from
cfa9dea to
37fe192
Compare
|
I have rebased (2x), removed " |
emilk
added a commit
that referenced
this pull request
Jan 31, 2025
This should produce better error messages when running Rerun Wasm outside of a browser. Required because of * #8745
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Part of: #6330
What
crates/viewer/re_viewer/src/lib.rs. unwrap_or_elsewith panic in 1 case#[allow(clippy::unwrap_used)]directives in limited, focused cases.expectwith descriptive messages in all other cases(no changelog updates)
General rationale:
Most of the cases using
.unwrapseem to need these to work. I think the best solution is to use.expectwith a clear message in most of these cases.Sanity checks done:
These succeed for me with no warnings:
cargo clippy -p re_viewer --all-featurescargo build -p re_viewer --all-featurescargo fmtdoes not introduce inconsistent formatting of the updated code