Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legacy and next-gen partial updates snippets for all languages #8649

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add legacy and next-gen partial updates snippets for all languages #8649

merged 1 commit into from
Jan 13, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 10, 2025 •
edited
Loading

This adds a partial update example for Points3D, in all languages, using both the legacy and new APIs (if they already exist).

This acts as a before/after comparison, a piece of documentation and a way to make sure that the legacy and new APIs behave similarly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8649 | +nightly +main |

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc mentioned this pull request Jan 10, 2025
Merged
@teh-cmc teh-cmc added 🔨 testing testing and benchmarks examples Issues relating to the Rerun examples do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages 📖 documentation Improvements or additions to documentation labels Jan 10, 2025
@teh-cmc teh-cmc marked this pull request as ready for review January 10, 2025 16:24
@emilk emilk self-requested a review January 10, 2025 17:58
zehiko
zehiko approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zehiko zehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@teh-cmc teh-cmc force-pushed the cmc/eager_partial_5_flaky_roundtrips branch from bbe01a7 to a4852e9 Compare January 13, 2025 08:39
Base automatically changed from cmc/eager_partial_5_flaky_roundtrips to main January 13, 2025 08:42
@teh-cmc teh-cmc force-pushed the cmc/eager_partial_6_and_snippets_for_all branch from 55800f3 to ba709f9 Compare January 13, 2025 08:44
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 13, 2025
@teh-cmc teh-cmc merged commit e905439 into main Jan 13, 2025
34 of 35 checks passed
@teh-cmc teh-cmc deleted the cmc/eager_partial_6_and_snippets_for_all branch January 13, 2025 08:45
teh-cmc added a commit that referenced this pull request Jan 13, 2025
@teh-cmc
Eagerly serialized, partially updatable 2D & 3D line strips (#8650)
e26d858 
This PR makes `LineStrips2D` and `LineStrips3D` eagerly serialized and
partially update-able.

This demonstrates how to migrate an archetype in the simple case.

* DNM: requires #8649  
* Part of #8581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehiko zehiko zehiko approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teh-cmc @emilk @zehiko