-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New types and traits for (co-existing!) eager serialization #8642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
teh-cmc
added
enhancement
New feature or request
🦀 Rust API
Rust logging API
🍏 primitives
Relating to Rerun primitives
include in changelog
labels
Jan 10, 2025
emilk
approved these changes
Jan 10, 2025
teh-cmc
added a commit
that referenced
this pull request
Jan 13, 2025
…8643) Generate methods for all archetypes that allow retrieving the fully-qualified descriptor for any of the archetype's field. E.g. this method returns the descriptor for the `radii` field of `Points3D`: ```rust impl Points3D { /// Returns the [`ComponentDescriptor`] for [`Self::radii`]. #[inline] pub fn descriptor_radii() -> ComponentDescriptor { ComponentDescriptor { archetype_name: Some("rerun.archetypes.Points3D".into()), component_name: "rerun.components.Radius".into(), archetype_field_name: Some("radii".into()), } } } ``` This becomes a must as we start require tags in more and more places (e.g. partial updates APIs). * DNM: requires #8642 * Part of #8581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
include in changelog
🍏 primitives
Relating to Rerun primitives
🦀 Rust API
Rust logging API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
SerializedComponentBatch
, which will become the main type we use to carry user data around internally.The goal is to keep the
ComponentBatch
trait isolated at the edge, where it is used as a means of easily converting any data into arrow arrays, instead of simultaneously being used as a means of transporting data around through the internals.ComponentBatch
is here to stay, if only for its conversion capabilities.This opens a lot of opportunities of improvements in terms of DX, UX and future features (e.g. generics).
The two code paths will co-exist for the foreseeable future, until all archetypes have been made eager.