Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the unknown view class text #8302

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 3, 2024

Related

What

Update the unknown view ui. Now hints at enabling map_view if a map view was expected.

image

Note: I tried to make that message depend on the actual identifier that was used (to special case "map"), but bailed out if it as it messed too much with the view class registrar for my taste.

Now hints at enabling `map_view` if a map view was expected
Copy link

github-actions bot commented Dec 3, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
48e5607 https://rerun.io/viewer/pr/8302

Note: This comment is updated whenever you push a commit.

Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@abey79 abey79 added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 3, 2024
@abey79 abey79 merged commit 97e8ed9 into main Dec 3, 2024
36 of 37 checks passed
@abey79 abey79 deleted the antoine/better-no-map-warning branch December 3, 2024 16:08
@emilk
Copy link
Member

emilk commented Dec 3, 2024

Nicely done ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when Geo* entities are logged and the viewer wasn't compiled with the map_view feature
3 participants