Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New code snippet for Transform3D demonstrating an animated hierarchy #6851

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 10, 2024

What

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation include in changelog labels Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

Deployed docs

Commit Link
d52fb30 https://landing-hhvh0l6uv-rerun.vercel.app/docs

@Wumpf Wumpf force-pushed the andreas/transform3d-hierarchy-snippet branch from 0af7c01 to cf5413a Compare July 10, 2024 21:20
@teh-cmc teh-cmc self-requested a review July 11, 2024 07:31
docs/snippets/all/archetypes/transform3d_hierarchy.py Outdated Show resolved Hide resolved
@@ -135,7 +135,9 @@ quick_start = [ # These examples don't have exactly the same implementation.
"py",
"rust",
]

"archetypes/transform3d_hierarchy" = [ # Uses a lot of trignometry which is suprisingly easy to get the same on Rust & C++, but not on Python/Numpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember having to deal with these kinds of shenanigans in the past -- iirc it's because numpy defaults to f64 for every computation internally. I don't remember if there's an easy way to change that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I tried to tell it to use f32 on its arrays, but it got fiddly - definitely got closer but not to the exact result

@Wumpf Wumpf merged commit 8d0598f into main Jul 11, 2024
6 of 9 checks passed
@Wumpf Wumpf deleted the andreas/transform3d-hierarchy-snippet branch July 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants