Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental setting flag to always enable visualizer selection #5215

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 16, 2024

What

Currently, we show visualizer overrides only in the time series view since we haven't tested this mechanism all that much. And it's true, stuff behind is is somewhat brittle! So this PR allows you to test it by adding a new experimental flag!

This is what I wanted to get, but it requires some more work unfortunately:
image

Things missing for the demonstrated usecase:

  • Image visualizer has this snippet to protect against showing both a depth and image texture.
        // If this isn't an image, return
        // TODO(jleibs): The ArchetypeView should probably do this for us.
        if !ctx.entity_db.store().entity_has_component(
            &ctx.current_query().timeline,
            ent_path,
            &Image::indicator().name(),
        ) {
            return Ok(());
        }
* Really what we need to do here is to split up the image visualizer into several. We can do this now! It's a similar problem like the one we solved in time series view
  • 2D view freaks out when the origin is not set to world/Lantern because 2D view takes great interest in 3D transforms that confuse the hell out of it

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 16, 2024
@Wumpf Wumpf merged commit 2ba508d into main Feb 17, 2024
41 of 43 checks passed
@Wumpf Wumpf deleted the andreas/experimental-visualizer-selection branch February 17, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants