Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce input latency by switching to double-buffered rendering #4575

Closed
wants to merge 1 commit into from

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 18, 2023

This makes a huge difference in perceived latency on my 60 Hz monitor on macOS on a native build, e.g. when hovering buttons, or just the distance between the cursor and the hover-window when hovering an image.

It does produce some tearing, noticable e.g. when quickly panning a 2D image. To me the trade-off is absolutely worth it: tearing is a mild visual glitch that shows up occationally, input latency is a constant irritation, making an application feel sluggish.

It makes no difference on web though, so this does NOT solve #2672

I also switched the defaults in eguo-wgpu: emilk/egui#3714

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

This makes a huge difference in perceived latency on my 60 Hz monitor
on macOS on a native build, e.g. when hovering buttons,
or just the distance between the cursor and the hover-window
when hovering an image.

It does produce some tearing, noticable e.g. when quickly panning
a 2D image. To me the trade-off is absolutely worth it:
tearing is a mild visual glitch that shows up occationally,
input latency is a constant irritation, making an application feel
sluggish.

It makes no difference on web though, so this does NOT
solve #2672
@emilk emilk added 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself 🚀 performance Optimization, memory use, etc include in changelog labels Dec 18, 2023
@Wumpf
Copy link
Member

Wumpf commented Dec 18, 2023

@Wumpf
Copy link
Member

Wumpf commented Dec 19, 2023

@emilk emilk added the blocked can't make progress right now label Dec 19, 2023
@teh-cmc
Copy link
Member

teh-cmc commented Dec 21, 2023

Drafting to reduce visual clutter in the pending-review queue

@teh-cmc teh-cmc marked this pull request as draft December 21, 2023 08:14
@emilk
Copy link
Member Author

emilk commented Jan 23, 2024

Closed in favor of emilk/egui#3874

@emilk emilk closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked can't make progress right now include in changelog 🚀 performance Optimization, memory use, etc 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants