Enforce TODO formatting #3404
Merged
Enforce TODO formatting #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🧑💻 dev experience
teh-cmc
commented
Sep 22, 2023
Wumpf
approved these changes
Sep 22, 2023
| @@ -570,7 +570,7 @@ def __call__( | |||
| ) | |||
| rr.log_tensor("diffusion/latents", latents, names=["b", "c", "h", "w"]) | |||
|
|
|||
| # 8. Prepare extra step kwargs. TODO(original author): Logic should ideally just be moved out of the pipeline | |||
| # 8. Prepare extra step kwargs. TODO(someone): Logic should ideally just be moved out of the pipeline | |||
teh-cmc
force-pushed
the
cmc/todo_formatting
branch
from
2341b69 to
4537718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial PR to enforce the formatting of TODOs.
This is groundwork for an upcoming PR that checks for zombie TODOs on CI (TODOs that reference an issue that is already fixed).
TL;DR: these are legal, everything else is not (hopefully):
TODO(bob)TODO(bob, alice)TODO(#42)TODO(#42, #43)TODO(rust-lang/rust#42)TODO(rust-lang/rust#42, rust-lang/rust#43)What
Checklist