Make the space views bigger and less cluttered #269
Conversation
emilk
force-pushed
the
emilk/cleaner-space-view-ui
branch
3 times, most recently
from
83ed6ba to
98b4190
Compare
|
something broke since you took the screenshots? |
|
ah. The problem is that there is text AND 3d, it can't handle that correctly right now. Also it shouldn't show up for text views |
| let frame = self.ctx.design_tokens.hovering_frame(ui.style()); | ||
| hovering_panel(ui, frame, response.rect, |ui| { | ||
| if ui | ||
| .button("🗖") | ||
| .on_hover_text("Maximize Space View") | ||
| .clicked() | ||
| { | ||
| *self.maximized = Some(*space_view_id); | ||
| } | ||
|
|
||
| let space_view = self | ||
| .space_views | ||
| .get_mut(space_view_id) | ||
| .expect("Should have been populated beforehand"); | ||
|
|
||
| space_view_ui(self.ctx, ui, self.spaces_info, space_view); | ||
| space_view_options_link( | ||
| self.ctx, | ||
| self.selection_panel_expanded, | ||
| *space_view_id, | ||
| ui, | ||
| "⛭", | ||
| ); |
There was a problem hiding this comment.
only show for 3d and 2d space views? Placing isn't great right now when we have both text and 3d/2d subviews
There was a problem hiding this comment.
I agree placing isn't great, but I think users should still be able to maximize and go to settings for tensor views and text log views.
|
I introduced this bug in egui (weird extra distance between tooltips). EDIT: found the bug: emilk/egui#2264 |
emilk
force-pushed
the
emilk/cleaner-space-view-ui
branch
from
27d0600 to
a082ef0
Compare
|
Could we move down the controls into the same bar where we have the space view title for text and always go into the viewport if possible for "viewports"? |
| tensor: Tensor, | ||
| } | ||
|
|
||
| fn empty_tensor() -> Tensor { |
There was a problem hiding this comment.
Because it makes some arbitrary decisions on dtype
|
I'll see if I can make the space view buttons for view_text and view_tensor better in a later PR. |
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
emilk
force-pushed
the
emilk/cleaner-space-view-ui
branch
from
49f1321 to
7791a80
Compare
Part of PRO-186
I need to merge this first:
What?
This PR moves all of the 3D view's options, and most of the tensor view's options, to the selection panel.
Then, it puts a link to the space view options, together with a "?" help menu and an maximize-button (when needed) on top of the 3D and 2D space views (partially covering their content).
This is not possible for the tensor and text log views, so there some extra "headroom" is needed to fit the above buttons (still better than before though).
Before
After
More screenshots
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)