Fix greyscale colormapping being not gamma-corrected #2456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix
colormap_srgb
outputting linear greyscale map instead of srgb greyscale map.Note how this method is documented as:
/// Returns a gamma-space sRGB in 0-1 range.
but then a few lines below outputted
Vec3(t)
directly, i.e. a linear scale.This became visually apparent when you put a 3 channel image (no color map!) next to a single channel image (greyscale color map applied) next to each other.
Before:
After:
(this is not what the sample usually looks like, I made both images take the value 128, they are different by default)
Checklist
PR Build Summary: https://build.rerun.io/pr/2456
Docs preview: https://rerun.io/preview/1c35935/docs
Examples preview: https://rerun.io/preview/1c35935/examples