[re_renderer] shader import cleanup & wgsl typedefs #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Oct 26, 2022
emilk
approved these changes
Oct 26, 2022
teh-cmc
approved these changes
Oct 26, 2022
emilk
pushed a commit
that referenced
this pull request
Oct 26, 2022
* moved out some shader utility functions * add shader type aliases * fix use of let/var
emilk
added a commit
that referenced
this pull request
Oct 27, 2022
* Add documentation for the new space transform hierarchy system * pylint * Remove calls to rerun.log_camera and space=… * Python SDK: Remove space= arguments and log_camera * Remove old viewport panel * Remove the Camera data type and object type * Fix the vscode extensions list * Remove `space` field from objects * More "space" removal * Add "crates" to recommended VSCode extension list * one more * Add line to changelog * Remove space from benchmark (we don't need it!) * Refactor out function should_have_default_view * Automatically add space views if the viewport is missing a space * Bug-fix * Nicer split * Improve USAGE.md text * Link to USAGE.md from changelog line * Explain transform relationship * Even better USAGE.md * Explain what Rerun means with "Space" * Add log_unknown_transform * Add CoordinateSystem data type * Replace `set_space_up` with `log_world_coordinate_system` * Better plumbing of the space coordinate systems * Handle no views * Log camera coordinate systems and use it * Remove CameraSpaceConvention * Move SpaceCamera to own file * Move SpaceCamera to own file * Rename "Extrinsics" to "Rigid3" * python format and lint * Make intrinsics resolution optional * Code cleanup * Unify everything as "ViewCoordinates" * Respect world view coordinates when setting up default 3D eye * Fix mistaken confusion of rub-space and user cam-space * Fix correct axes preview of camera in 3d space * Add a TODO about camera frustum * Rename intrinsics to pinhole * For convenience, log_rigid3_transform also takes a xyz argument * Document view coordinates * Misc cleanup * Fix direction of the clock example so that X=right and Y=up * cargo doc fix * wording Co-authored-by: Nikolaus West <[email protected]> * better docstring Co-authored-by: Nikolaus West <[email protected]> * [re_renderer] shader import cleanup & wgsl typedefs (#229) * moved out some shader utility functions * add shader type aliases * fix use of let/var * log_rigid3_transform -> log_rigid3 * Improve docs * More improved docs * Remove deprecated docs about automatic space names * rename "3d" to "world" * Add info about log_unknown_transform to USAE.md * log_rigid3: add parent_from_child and child_from_parent parameters * log_pinhole: rename argument to child_from_parent Co-authored-by: Nikolaus West <[email protected]> Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
letvsvarSadly I found a bug in Naga while doing the type aliases - gfx-rs/naga#2105
Checklist
* [ ] I've included a screenshot or gif (if applicable)* [ ] I've added a line toCHANGELOG.md(if this is a big enough change to warrant it)