Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View frustum lines cross over image plane instead of going around #2660

Closed
Wumpf opened this issue Jul 10, 2023 · 0 comments · Fixed by #2667
Closed

View frustum lines cross over image plane instead of going around #2660

Wumpf opened this issue Jul 10, 2023 · 0 comments · Fixed by #2667
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release

Comments

@Wumpf
Copy link
Member

Wumpf commented Jul 10, 2023

Regression introduced in #2614

https://demo.rerun.io/pr/2614/examples/arkit_scenes/
image
@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Jul 10, 2023
@Wumpf Wumpf changed the title incorrect view frustum lines View frustum lines cross over image plane instead of going around Jul 10, 2023
@Wumpf Wumpf added 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less labels Jul 10, 2023
@Wumpf Wumpf mentioned this issue Jul 11, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Jul 13, 2023
@Wumpf
Fix camera tracking delay/flicker (#2667)
95e9756 
Fixes #2201 
* #2201
 
The issue is about the lines flickering in and out and the proposed
solution was to not render the lines. But turns out the image itself was
also flickering when I tested with structure_from_motion sample. Turned
out we didn't accurately track the camera, doing so works perfectly fine
and doesn't need special handling on the frustum lines.

Fixes #2660 
* #2660 

I thought this was related (because I thought above would be about
hiding lines), but now this is a regression fix that is just piggy
backing here. PR description is about the thing that was actually broken
in a release (but presumably worked before)

Test it yourself:
* got to https://demo.rerun.io/pr/2667
* click camera - observe the frustum lines are correct now
* double click the camera to focus on it and play - no flickering should
occur
* try the same while the camera is already moving


### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2667) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2667)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-frustum-line-issues/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-frustum-line-issues/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix camera tracking delay/flicker rerun-io/rerun
1 participant
@Wumpf