Skip to content

Commit

Permalink
Enable GH releases for RC (#8524)
Browse files Browse the repository at this point in the history
This PR enables the creation of GH releases (as draft and marked as
pre-release) for RCs.

Motivations for doing so:
- test that part of the workflow, in particular that all binaries are
correctly produced
- test the binary using `cargo binstall`
- these releases a single-click deletable from GH (if we want to do so)
- GH releases marked as "pre-release" aren't displayed in the GH project
page

Pending questions: do we want that?  what about alphas?
  • Loading branch information
abey79 authored Dec 18, 2024
1 parent 5b62c37 commit e9d0476
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ jobs:
github-release:
name: "GitHub Release"
if: inputs.release-type == 'final'
if: inputs.release-type == 'rc' || inputs.release-type == 'final'
needs:
[
version,
Expand All @@ -347,9 +347,16 @@ jobs:
run: |
version="${{ needs.version.outputs.final }}"
commit="${{ needs.version.outputs.release-commit }}"
if [ ${{ inputs.release-type }} = "final" ]; then
pre_arg=""
else
pre_arg="--prerelease"
fi
git tag $version $commit
git push origin $version
gh release create $version --verify-tag --draft --title $version
gh release create $version --verify-tag --draft --title $version $pre_arg
- name: Create comment
env:
Expand Down

0 comments on commit e9d0476

Please sign in to comment.