Skip to content

Commit

Permalink
Prevent flaky roundtrips in rerun rrd compare (#8648)
Browse files Browse the repository at this point in the history
Store-side compaction has election heuristics that can yield different
results depending on the order in which the chunks arrive.
This can make some cross-language roundtrip tests flaky.

This PR makes sure to disabled store-side compaction when running RRD
comparison tests.

* DNM: requires #8647
  • Loading branch information
teh-cmc authored Jan 13, 2025
1 parent 1b9e510 commit 822a192
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion crates/top/rerun/src/commands/rrd/compare.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,14 @@ fn compute_uber_table(
let msg = msg.context("decode rrd message")?;
stores
.entry(msg.store_id().clone())
.or_insert_with(|| re_entity_db::EntityDb::new(msg.store_id().clone()))
.or_insert_with(|| {
re_entity_db::EntityDb::with_store_config(
msg.store_id().clone(),
// We must make sure not to do any store-side compaction during comparisons, or
// this will result in flaky roundtrips in some instances.
re_chunk_store::ChunkStoreConfig::ALL_DISABLED,
)
})
.add(&msg)
.context("decode rrd file contents")?;
}
Expand Down

0 comments on commit 822a192

Please sign in to comment.