Fix crash when error_event does not have "message" or "error" fields #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
May 24, 2024
ewebsock/src/web.rs
Outdated
Comment on lines
153
to
154
| let message = js_sys::Reflect::get(&error_event, &"message".into()).unwrap(); | ||
| let error = js_sys::Reflect::get(&error_event, &"error".into()).unwrap(); |
There was a problem hiding this comment.
We should probably replace these unwraps with a fallback, e.g. using unwrap_or_default, otherwise we just get another crash at another time
There was a problem hiding this comment.
You are right. I just changed to unwrap_or_default.
I do not think it could actually crash, but it looked ugly.
emilk
approved these changes
May 24, 2024
|
There's a clippy warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #25