Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.0 translations #998

Merged
merged 1 commit into from
May 28, 2020
Merged

v0.9.0 translations #998

merged 1 commit into from
May 28, 2020

Conversation

iGormilhit
Copy link

Why are you opening this PR?

To sync github and transifex.

How to test?

Check the translations files.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@iGormilhit iGormilhit added this to the v0.9.0 milestone May 19, 2020
@iGormilhit iGormilhit added the translations Translations label May 19, 2020
@iGormilhit iGormilhit self-assigned this May 19, 2020
Reverts in the document JSON schema the title value of the person JSON
reference, mainly to avoid translating it again.

Removes codes that were added to the manual translations but are not
displayed on the document detailed view.

Fixes the custom extraction script with a better regex to identify only
label and not labelSomething in the JSON schemas.

Co-Authored-by: Igor Milhit <[email protected]>
@iGormilhit iGormilhit marked this pull request as ready for review May 28, 2020 10:57
@iGormilhit iGormilhit requested review from jma and rerowep and removed request for rerowep May 28, 2020 10:58
@iGormilhit iGormilhit merged commit c129cea into rero:dev May 28, 2020
@iGormilhit iGormilhit deleted the v0.9.0-translations branch May 28, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants