db: separate tables #959
Merged
db: separate tables #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
wep-#1382-seperate-tables
branch
3 times, most recently
from
7a3f5fb to
00283e7
Compare
BadrAly
approved these changes
Apr 30, 2020
rerowep
force-pushed
the
wep-#1382-seperate-tables
branch
from
00283e7 to
6330981
Compare
iGormilhit
suggested changes
May 4, 2020
There was a problem hiding this comment.
Commit message, with small corrections:
db: separate tables
* Creates for every resource a separate metadata and id table in the database.
Is it one table per resource, or two table per resource? If it's only one then simplify like this:
* Creates for every resource a separate database table.
If it two, then your proposal is ok.
And try to explain the benefit of this separation. 🙂
rerowep
force-pushed
the
wep-#1382-seperate-tables
branch
2 times, most recently
from
7993953 to
f79ebc8
Compare
zannkukai
approved these changes
May 6, 2020
lauren-d
approved these changes
May 6, 2020
rerowep
force-pushed
the
wep-#1382-seperate-tables
branch
from
f79ebc8 to
9c1c777
Compare
* Creates for every resource a separate metadata and id table in the database. With this change export and import of one resource should be easier and the access to seperate smaler tables are hopefully faster for big datasets. Co-Authored-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
wep-#1382-seperate-tables
branch
from
9c1c777 to
c1ec9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
How to test?
Code review check list