Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: fix key source issues #909

Merged
merged 1 commit into from
Apr 9, 2020
Merged

translation: fix key source issues #909

merged 1 commit into from
Apr 9, 2020

Conversation

iGormilhit
Copy link

@iGormilhit iGormilhit commented Apr 8, 2020

When translating on transifex, translators identify some source strings
that have to be improved or amended. This commit fixes a good part of
the current issues. The description fields of the schema of patron
transaction and patron transaction event have been removed in order to
avoid the need to translate them on transifex.

  • Updates sources files.
  • Updates source language files.
  • Update translation files.
  • Extracts messages.
  • Updates catalogs.

Co-Authored-by: Igor Milhit [email protected]

Why are you opening this PR?

To fix source string issues identified on transifex.

How to test?

  • Check changes.
  • Run tests.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@iGormilhit iGormilhit added the translations Translations label Apr 8, 2020
@iGormilhit iGormilhit added this to the v0.7.0 milestone Apr 8, 2020
@iGormilhit iGormilhit self-assigned this Apr 8, 2020
@iGormilhit iGormilhit requested a review from BadrAly April 9, 2020 07:11
@iGormilhit iGormilhit marked this pull request as ready for review April 9, 2020 11:08
@iGormilhit iGormilhit requested a review from pronguen April 9, 2020 11:10
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems me okay, but why did you add a point at the end of Discount percentage.?

When translating on transifex, translators identify some source strings
that have to be improved or amended. This commit fixes a good part of
the current issues. The description fields of the schema of patron
transaction and patron transaction event have been removed in order to
avoid the need to translate them on transifex.

* Updates sources files.
* Updates source language files.
* Update translation files.
* Extracts messages.
* Updates catalogs.

Co-Authored-by: Igor Milhit <[email protected]>
@jma jma merged commit 46db2e8 into rero:dev Apr 9, 2020
@iGormilhit iGormilhit deleted the source-string-issues branch May 20, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants