git: integrate US1232 into dev #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reropag
force-pushed
the
US1232-data-model-title-and-variants
branch
from
e59d260 to
2ca5138
Compare
|
Test création notice : champ titre : rien à signaler de particulier par rapport aux spécifications.
|
pronguen
reviewed
Apr 7, 2020
There was a problem hiding this comment.
1.
Some punctuation marks are still present in the data, and therefore are displayed twice. They come from zones 880 where the alphabet is from right to left (and maybe also from 245/250/264 with such alphabets).
In thoses cases, we have to remove the punctuation *in the beginning of the zone (see below - might be difficult to find a solution for / but it is not that worse).
2.
When importing this document 9782952820646 from BnF, the statement of responsibility is imported twice in two languages (4 in total). If I save and reopen it, I have only one displayed in the editor.
(3.)
See eventually #906
jma
force-pushed
the
US1232-data-model-title-and-variants
branch
from
b7626d3 to
0f3dfba
Compare
* Implements title and variants transformation for Marc21. * Implements title and variants transformation for Marc21 eBook. * Adapts ES mapping. * Adapts JSON schemas. * Adapts detailed document view. Related to: rero-ils-ui pr200 document: display title in brief and detail view Co-Authored-by: Gianni Pante <[email protected]> Co-Authored-by: Peter Weber <[email protected]>
* Implements title and variants transformation for BnF UNIMARC. * Fixes title_format_text_head for handling AttrDict accordingly. * Adapts email templates to use new title format. * Improves the way for getting the _text form bf:Title. * Changes order of the display of title: original alphabet before transliteration. * Changes order of the display of responsibilityStatement: original alphabet before transliteration. * Changes order of the display of editionStatement: original alphabet before transliteration. * Changes order of the display of provisionActivity: original alphabet before transliteration. * Closes #876. * Fixes bug in document JSONSchemas that prevent saving new document record in the editor. Co-Authored-by: Gianni Pante <[email protected]> Co-Authored-by: Peter Weber <[email protected]> Co-Authored-by: Johnny Mariethoz <[email protected]>
jma
force-pushed
the
US1232-data-model-title-and-variants
branch
from
0f3dfba to
f4e3e08
Compare
* Adapts transformation for unimarc for vernacular language support. * Adapts JSON schemas. * Fixes responsibiliyStatement transformation to avoid duplicates. Co-Authored-by: Gianni Pante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
How to test?
Code review check list