security: fix bleach XSS security breach #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
Mar 18, 2020
jma
approved these changes
Mar 18, 2020
Pipfile
Outdated
| @@ -69,6 +69,8 @@ pycountry = ">=19.7.15" | |||
| xmltodict = "*" | |||
| # TODO: to be removed when the thumbnail will be refactored | |||
| angular-gettext-babel= ">=0.1" | |||
| # Avoid CVE 38076 on bleach <=3.1.1 ( asked by invenio-record-rest) | |||
There was a problem hiding this comment.
I would write something like: dependency of invenio-record-reset to avoid confusion.
There was a problem hiding this comment.
You're right, I change it!
BadrAly
approved these changes
Mar 18, 2020
blankoworld
force-pushed
the
doo-fix-bleach-version
branch
from
969660c to
367b562
Compare
Tests were broken because of a security breach in bleach <=3.1.1. * Fixes bleach version to upgrade to bleach > 3.1.1 Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
doo-fix-bleach-version
branch
from
367b562 to
4904c44
Compare
rerowep
reviewed
Mar 18, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were broken because of a security breach in bleach <=3.1.1.
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
A problem occurs in tests today:
How to test?
docker-compose down pipenv --rm pipenv run bootstrap docker-compose up -d && ./docker/wait-for-services.sh ./run-tests.shTest shouldn't display the problem with bleach 3.1.1 breach.
Code review check list