Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: fix request made by a librarian #843

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Mar 11, 2020

  • Reformulates messages:

Circulation policies do not allow request on this item > Request not allowed by the circulation policy
Your new request has been registered > Request registered

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

To implement task 1353 of US657
https://tree.taiga.io/project/rero21-reroils/task/1353?kanban-status=1224894
See https://gitter.im/rero/reroils-PO?at=5e65f10102dbe022a175fa76

How to test?

N/A

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami self-assigned this Mar 11, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1353-fix-librarian-request branch from d0e88c5 to 1ddfe89 Compare March 11, 2020 16:02
@AoNoOokami AoNoOokami force-pushed the zaa-#1353-fix-librarian-request branch from 1ddfe89 to 6b0937b Compare March 13, 2020 07:03
@AoNoOokami AoNoOokami requested a review from zannkukai March 13, 2020 09:11
@AoNoOokami AoNoOokami force-pushed the zaa-#1353-fix-librarian-request branch from 6b0937b to 8585dd3 Compare March 13, 2020 15:56
@benerken benerken self-requested a review March 16, 2020 13:39
@AoNoOokami AoNoOokami force-pushed the zaa-#1353-fix-librarian-request branch from 8585dd3 to ca1defc Compare March 16, 2020 15:34
* Reformulates messages:

Circulation policies do not allow request on this item > Request not allowed by the circulation policy
Your new request has been registered > Request registered

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-#1353-fix-librarian-request branch from ca1defc to 1332b2f Compare March 16, 2020 15:35
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved. Thanks.

@pronguen pronguen self-requested a review March 17, 2020 06:55
@AoNoOokami AoNoOokami merged commit bdaff2a into rero:dev Mar 17, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1353-fix-librarian-request branch April 20, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants