Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patron editor: add placeholders #815

Merged
merged 1 commit into from
Mar 3, 2020
Merged

patron editor: add placeholders #815

merged 1 commit into from
Mar 3, 2020

Conversation

AoNoOokami
Copy link
Contributor

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami self-assigned this Feb 28, 2020
@AoNoOokami AoNoOokami requested review from jma and BadrAly March 2, 2020 06:55
jma
jma approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messages.po should not be a part of this commit.

@AoNoOokami AoNoOokami force-pushed the zaa-patron-editor-placeholders branch from 9a8da8a to b481034 Compare March 2, 2020 10:28
@AoNoOokami
Copy link
Contributor Author

messages.po should not be a part of this commit.

Indeed. Removed.

patron editor: add placeholders
50d3e90 
* Adds placeholders for phone number and date of birth fields.
* Closes rero#538.
* Closes rero#804.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-patron-editor-placeholders branch from b481034 to 50d3e90 Compare March 2, 2020 10:47
@AoNoOokami AoNoOokami requested review from lauren-d, zannkukai and sebdeleze and removed request for BadrAly and lauren-d March 3, 2020 07:19
@AoNoOokami AoNoOokami removed the request for review from sebdeleze March 3, 2020 09:56
@AoNoOokami AoNoOokami merged commit 0ce3f6c into rero:dev Mar 3, 2020
@AoNoOokami AoNoOokami deleted the zaa-patron-editor-placeholders branch March 3, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees

@AoNoOokami AoNoOokami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AoNoOokami @jma @sebdeleze @zannkukai