Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: fix automatic checkin return informations #774

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

zannkukai
Copy link
Contributor

Co-Authored-by: Renaud Michotte [email protected]

How to test?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai self-assigned this Feb 19, 2020
@zannkukai zannkukai requested review from rerowep, jma and BadrAly February 19, 2020 14:57
@zannkukai zannkukai force-pushed the zan-#fix-772-display-transit-info branch from eb3a3e3 to 8dab3ad Compare February 19, 2020 14:59
@zannkukai zannkukai requested a review from benerken February 19, 2020 14:59
Copy link
Contributor

@benerken benerken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the most beautiful fix I have never seen :-)

* Fixes automatic_checkin return informations
* Closes rero#770

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-#fix-772-display-transit-info branch from 8dab3ad to 7c92b33 Compare February 19, 2020 15:26
@iGormilhit iGormilhit merged commit a522bfa into rero:dev Feb 19, 2020
@zannkukai zannkukai deleted the zan-#fix-772-display-transit-info branch February 20, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants