US813 #714
Merged
US813 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2020 11:42
* Adds loan.pid , patron.pid, and organisation.currency to the resource fee es index. * Fixes units testing problem with overdue fees creation. * Increases fees unit testing fixtures and third organisation fixtures. * Removes currency field from resource fee. * Removes the option --fee from the loan creation cli. Co-Authored-by: Aly Badr <[email protected]>
* Adds sort order parameter to the item.requested_loans.library_pid api. * Adds sort order parameter to the item.loans.patron_barcode api. * Improves notification fixtures to have due_soon and recall records. * Fixes item fixtures problem. Co-Authored-by: Aly Badr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
How to test?
Code review check list