Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mef: new data and corrections #685

Closed
wants to merge 1 commit into from
Closed

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 7, 2020

Why are you opening this PR?

  • 1172

How to test?

  • You have to use mefdev.test.rero.ch for testing.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message:

persons: update and fix persons data

* Fixes viaf-pid in mef records.
* Closes #30.
* Closes #555.
* Closes #657.
* Tests for duplicated pids.
* Updates viaf, rero, gnd data.
* Adapts format transformation (024 $0).

Is it actually issue #30 that this commit fixes?

It adapts format transformation only for GND (last item of the commit)?

@rerowep rerowep force-pushed the wep-#1172-mef-pr37 branch 2 times, most recently from cc746b7 to b61e8c4 Compare January 10, 2020 14:30
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message items seems not correspond to the code as only the data files has been changed.

@rerowep rerowep force-pushed the wep-#1172-mef-pr37 branch from b61e8c4 to fb91562 Compare January 14, 2020 08:08
@rerowep rerowep self-assigned this Jan 14, 2020
@rerowep rerowep force-pushed the wep-#1172-mef-pr37 branch 2 times, most recently from 92e1e5f to 6afad7c Compare January 14, 2020 09:38
@rerowep rerowep force-pushed the wep-#1172-mef-pr37 branch 4 times, most recently from 4d806f2 to 2f8bc89 Compare January 20, 2020 13:45
@rerowep rerowep force-pushed the wep-#1172-mef-pr37 branch 3 times, most recently from 0d72a65 to 2a7e047 Compare January 27, 2020 15:06
@rerowep rerowep force-pushed the wep-#1172-mef-pr37 branch from 2a7e047 to cbee5ee Compare January 29, 2020 12:17
* Updats documents data for rero/rero-mef#37.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep added f: mef Related to authorites or the MEF server needs info labels Mar 3, 2020
@rerowep rerowep closed this Mar 25, 2020
@rerowep rerowep deleted the wep-#1172-mef-pr37 branch April 23, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: mef Related to authorites or the MEF server needs info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants