loans: improve due date timezone consideration #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
approved these changes
Jan 7, 2020
BadrAly
suggested changes
Jan 7, 2020
There was a problem hiding this comment.
-
good job 👍
-
This test fails locally with this error:
pyt tests/api/test_loans_rest.py
# Compare year, month and date for Loan due date: should be the same!
fail_msg = "Check timezone for Loan and Library. It should be the same date, \
even if timezone changed."
assert loan_datetime.year == lib_datetime.year, fail_msg
assert loan_datetime.month == lib_datetime.month, fail_msg
> assert loan_datetime.day == lib_datetime.day, fail_msg
E AssertionError: Check timezone for Loan and Library. It should be the same date, even if timezone changed.
E assert 13 == 20
E -13
E +20
Any idea?
- This PR should now fix the two
TODOs in the filetests/api/test_items_rest.py:
line 632: # TODO: check why this test fails with this error @ travis
line 1248: # TODO: check whey this test fails with this error @travis
Could you please check this, thanks?
blankoworld
force-pushed
the
doo-#1136-due-date
branch
2 times, most recently
from
4495b4b to
c04f993
Compare
blankoworld
force-pushed
the
doo-#1136-due-date
branch
2 times, most recently
from
c6bccf0 to
3d29507
Compare
* Closes rero#599 by using correct timezone for due date (it takes into account opening hours and exception dates correctly) * tests due date timezone * adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default * changes due date process to take into account Library timezone * adds library_pid property on Loan objects Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
doo-#1136-due-date
branch
from
3d29507 to
c0d0088
Compare
iGormilhit
approved these changes
Jan 13, 2020
BadrAly
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
Cf. https://tree.taiga.io/project/rero21-reroils/task/1136 and #599
How to test?
It's explained in #599 . Pay attention to circulation policy and dates.
Code review check list