Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter persons view #674

Merged
merged 1 commit into from
Jan 7, 2020
Merged

filter persons view #674

merged 1 commit into from
Jan 7, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Dec 16, 2019

Why are you opening this PR?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep force-pushed the wep-#1188-persons-filter branch 3 times, most recently from 733a5c3 to 415e858 Compare December 16, 2019 11:59
@rerowep rerowep self-assigned this Dec 17, 2019
@AoNoOokami AoNoOokami self-requested a review December 18, 2019 10:43
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch 3 times, most recently from aa745a8 to 13aad87 Compare December 18, 2019 15:15
@AoNoOokami AoNoOokami mentioned this pull request Dec 18, 2019
6 tasks
scripts/setup Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch 2 times, most recently from a061c28 to 121db33 Compare December 20, 2019 08:14
rero_ils/modules/persons/api.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch 2 times, most recently from 80d6d9c to efe8688 Compare December 20, 2019 10:57
@rerowep rerowep requested a review from lauren-d December 20, 2019 10:57
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch from efe8688 to 40b3d73 Compare December 20, 2019 13:34
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch from 40b3d73 to 9b08df5 Compare January 4, 2020 13:35
rero_ils/modules/documents/api.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/api.py Outdated Show resolved Hide resolved
rero_ils/modules/persons/api.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch from 9b08df5 to 7dcb478 Compare January 6, 2020 09:26
@rerowep rerowep requested a review from jma January 6, 2020 09:26
rero_ils/modules/documents/api.py Outdated Show resolved Hide resolved
@iGormilhit iGormilhit self-requested a review January 6, 2020 10:58
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change ´Better indexing of person during document indexing´ to ´Improves persons (authors) indexing during document indexing.´

@rerowep rerowep force-pushed the wep-#1188-persons-filter branch 2 times, most recently from c4c527a to 96eb1a0 Compare January 6, 2020 13:55
@rerowep rerowep requested review from jma, BadrAly and iGormilhit January 6, 2020 13:59
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch from 96eb1a0 to 094370b Compare January 6, 2020 14:29
* Adds `organisations` to persons ES index.
* Improves persons (authors) indexing during document indexing.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1188-persons-filter branch from 094370b to dd2d7a9 Compare January 6, 2020 15:51
@rerowep rerowep merged commit 365ba62 into rero:dev Jan 7, 2020
@rerowep rerowep deleted the wep-#1188-persons-filter branch January 7, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants