Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add icons by doc type #65

Merged
merged 1 commit into from
Aug 9, 2018
Merged

feat: add icons by doc type #65

merged 1 commit into from
Aug 9, 2018

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Aug 9, 2018 •
edited
Loading

Signed-off-by: Aly Badr [email protected]
Co-authored-by: Bertrand Zuchuat [email protected]

How to test:

  • git reroils_app PR#65 and reroils_data PR#44
  • invenio collect -v
  • run_tests.sh
  • place any bibliographic search and make sure icons are present by doc type in the Full View and Brief View

@Garfield-fr
feat: add iconts by doc type
d1e45a9 
Signed-off-by: Aly Badr <[email protected]>
Co-authored-by: Bertrand Zuchuat <[email protected]>
@BadrAly BadrAly changed the title feat: add iconts by doc type feat: add icons by doc type Aug 9, 2018
@iGormilhit iGormilhit requested review from iGormilhit and removed request for iGormilhit August 9, 2018 11:59
@rerowep rerowep self-requested a review August 9, 2018 12:08
rerowep
rerowep approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel has an older version.

@rerowep rerowep merged commit b412983 into rero:master Aug 9, 2018
@BadrAly BadrAly deleted the baa-#612-add-doc-type-icons branch January 10, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BadrAly @rerowep