Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: Adds dump for documents #618

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Nov 12, 2019

Why are you opening this PR?

How to test?

  • setup

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposal:

data: add dump function for documents

* Computes `_text` field for provisionActivity and series to documents, to display unstructured statement from the structured data.

Co-Authored-by: Peter Weber <[email protected]>

@rerowep rerowep force-pushed the wep-#1147-pre-calculated-text branch 2 times, most recently from 4abced5 to 5e06205 Compare November 12, 2019 19:33
@rerowep rerowep requested a review from iGormilhit November 12, 2019 20:02
* Computes `_text` field for provisionActivity and series to documents, to display unstructured statement from the structured data.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1147-pre-calculated-text branch from 5e06205 to a9c614d Compare November 14, 2019 07:20
@rerowep rerowep merged commit 7ab6e9b into rero:dev Nov 14, 2019
@rerowep rerowep deleted the wep-#1147-pre-calculated-text branch November 17, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants