Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixtures: generate new files #472

Merged
merged 1 commit into from
Sep 5, 2019
Merged

fixtures: generate new files #472

merged 1 commit into from
Sep 5, 2019

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Sep 3, 2019 •
edited
Loading

  • Replaces big 10k (items, holdings, docs) files by small 1k files.
  • Improves code to insert pids to identifier table.
  • Adds extra language codes, needed for the transformation.
  • Fixes import problem for the transformation.

Co-Authored-by: Aly Badr [email protected]

jma
jma requested changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be a good idea to change the fixture file names to something more explicit such as big instead of 1k, small instead of 300. Includes the resource name in the fixtures file name would be also good.

@BadrAly
Copy link
Author

BadrAly commented Sep 3, 2019

It can be a good idea to change the fixture file names to something more explicit such as big instead of 1k, small instead of 300. Includes the resource name in the fixtures file name would be also good.

done

@BadrAly BadrAly requested a review from jma September 3, 2019 14:55
@BadrAly BadrAly force-pushed the baa-fixtures branch 2 times, most recently from 0ad7afd to 79948a6 Compare September 3, 2019 15:00
rerowep
rerowep requested changes Sep 3, 2019
View reviewed changes
scripts/setup Outdated Show resolved Hide resolved
scripts/setup Outdated Show resolved Hide resolved
@BadrAly BadrAly requested a review from rerowep September 3, 2019 15:13
fixtures: generate new files
4e3dfcb 
* Replaces 10k files by 1k file.
* Improves code to insert pids to identifier table.
* Fixes import problem for the transformation.
* Adds extra language codes, needed for the transformation.

Co-Authored-by: Aly Badr [email protected]
@iGormilhit iGormilhit merged commit b6ce492 into rero:dev Sep 5, 2019
@BadrAly BadrAly deleted the baa-fixtures branch September 9, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@rerowep rerowep rerowep approved these changes

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BadrAly @jma @rerowep @iGormilhit