Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US716 holdings level #458

Merged
merged 5 commits into from
Sep 2, 2019
Merged

US716 holdings level #458

merged 5 commits into from
Sep 2, 2019

Conversation

BadrAly
Copy link

@BadrAly BadrAly commented Aug 23, 2019

  • Adds holdings level between documents and items.
  • Adds automatic holding creation for new items based on item type and item location.
  • Adds automatic attaching of new items to a holding record if a valid holding record exists.
  • Adds automatic holding deletion once last item is deleted.
  • Adds automatic re-linking if necessary to a new holding when item is updated.
  • Adds holding structure on documents ES.
  • Removes items structure on documents ES.
  • Improves label pour one or more items link.
  • Filters result with Holdings information.

Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Aly Badr [email protected]

To test:

  • bootstrap, setup
  • create an item and make sure holding field is added to the item record
  • display the created holding record at 'http://localhost:5000/global/holdings/xx '
  • edit the item and change the item type or the location of the item
    ** make sure the item is re-attached to another holding.
  • delete the item and make sure the holding is also deleted by checking '/http://localhost:5000/global/holdings/xx '
    ** (if the item is the last attached to this holding)

@BadrAly BadrAly force-pushed the US716-holdings-level branch 3 times, most recently from 2c19fe6 to 977148c Compare August 26, 2019 12:15
Aly Badr and others added 3 commits September 2, 2019 08:39
* Adds holdings level between documents and items.
* Adds automatic holding creation for new items based on item type and item location.
* Adds automatic attaching of new items to a holding record if a valid holding record exists.
* Adds automatic holding deletion once last item is deleted.
* Adds automatic relinking if necessary to a new holding when item is updated.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Aly Badr [email protected]
* Adds holding structure on documents ES.
* Removes items structure on documents ES.
* Improves label pour one or more items link.
* Filters result with Holdings informations.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the US716-holdings-level branch from 19d3159 to 6f8e9df Compare September 2, 2019 06:40
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@BadrAly BadrAly force-pushed the US716-holdings-level branch from 6f8e9df to 7b29621 Compare September 2, 2019 07:03
* Removes automatic holding creation for the items of the fixtures.
* Adds separate json files for holdings data.
* Adds pid to item and holding fixtures files.
* Fixes problem when identifier table is not updated if incoming record has a pid.

Co-Authored-by: Aly Badr <[email protected]>
@jma jma merged commit 4ae44d8 into dev Sep 2, 2019
@BadrAly BadrAly deleted the US716-holdings-level branch September 4, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants