Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stats): make active patrons period 12 months #3819

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(stats): make active patrons period 12 months #3819

merged 1 commit into from
Feb 10, 2025

Conversation

PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented Feb 4, 2025 •
edited
Loading

  • The correct date range for number_of_active_patrons in the pricing stats should be 12 months and not the default RERO_ILS_STATS_BILLING_TIMEFRAME_IN_MONTHS.

@github-actions github-actions bot added the f: statistics Related to the usage statistics either for pricing or for the libaries reports label Feb 4, 2025
@PascalRepond PascalRepond force-pushed the rep-active-patrons branch 5 times, most recently from 0bdd175 to a674297 Compare February 4, 2025 12:34
@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Feb 4, 2025
@PascalRepond PascalRepond requested review from rerowep, mmo and jma February 4, 2025 12:42
jma
jma approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to write a test.

rero_ils/modules/stats/api/pricing.py Outdated Show resolved Hide resolved
@PascalRepond PascalRepond marked this pull request as draft February 5, 2025 07:58
@github-actions github-actions bot added the dev: documentation About changelog, release notes, installation procedures, gh templates... label Feb 5, 2025
@PascalRepond PascalRepond marked this pull request as ready for review February 5, 2025 10:25
@github-actions github-actions bot removed f: data About data model, importation, transformation, exportation of data, specific for bibliographic data dev: documentation About changelog, release notes, installation procedures, gh templates... labels Feb 6, 2025
@PascalRepond PascalRepond force-pushed the rep-active-patrons branch 2 times, most recently from 673b8bd to d619e98 Compare February 6, 2025 15:32
@PascalRepond PascalRepond requested a review from jma February 7, 2025 08:12
@PascalRepond
fix(pricing stats): make active patrons period 12 months
7d30a86 
- The correct date range for
`number_of_active_patrons` in the pricing
stats should be 12 months and not the default
`RERO_ILS_STATS_BILLING_TIMEFRAME_IN_MONTHS`.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond merged commit 1fcc96a into rero:staging Feb 10, 2025
4 checks passed
@PascalRepond PascalRepond deleted the rep-active-patrons branch February 10, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@rerowep rerowep rerowep approved these changes

@mmo mmo Awaiting requested review from mmo

Assignees

@PascalRepond PascalRepond

Labels
f: statistics Related to the usage statistics either for pricing or for the libaries reports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalRepond @jma @rerowep