Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dojson: fix contribution #2806

Merged
merged 1 commit into from
Apr 4, 2022
Merged

dojson: fix contribution #2806

merged 1 commit into from
Apr 4, 2022

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 1, 2022

  • Fixes creation of contribution.
  • Adds subjects to `get_all_mef_records.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Apr 1, 2022
@github-actions github-actions bot added developers From a developer point of view. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data labels Apr 1, 2022
@rerowep rerowep force-pushed the wep-fix-dojson-contribution branch 3 times, most recently from e17aeef to 52dcfd6 Compare April 1, 2022 20:16
@rerowep rerowep added this to the v1.10.0 milestone Apr 2, 2022
@rerowep rerowep requested a review from zannkukai April 4, 2022 07:45
@rerowep
dojson: fix contribution
10a8321 
* Fixes creation of contribution.
* Adds subjects to `get_all_mef_records.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-dojson-contribution branch from 52dcfd6 to 10a8321 Compare April 4, 2022 09:18
@rerowep rerowep merged commit 57bb7c9 into rero:staging Apr 4, 2022
@rerowep rerowep deleted the wep-fix-dojson-contribution branch April 6, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken Awaiting requested review from benerken

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@rerowep rerowep

Labels
developers From a developer point of view. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @zannkukai @BadrAly @lauren-d