Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selfcheck: add column for comments #2744

Merged
merged 1 commit into from
Mar 10, 2022
Merged

selfcheck: add column for comments #2744

merged 1 commit into from
Mar 10, 2022

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Mar 3, 2022 •
edited
Loading

  • Adds a new column in the selfcheck terminals table.
  • Updates selfcheck CLI.

Data Migration Instructions:

  • Run alembic script b90f8b148948_add_column_to_selfcheck_terminals.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d added the enhancement Improvement of an existing feature label Mar 3, 2022
@lauren-d lauren-d self-assigned this Mar 3, 2022
@github-actions github-actions bot added dev: DB Database structure (models.py) f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version labels Mar 3, 2022
@lauren-d lauren-d added this to the v1.10.0 milestone Mar 3, 2022
@lauren-d lauren-d added f: data migration Data migration from a legacy system or a previous version and removed f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version labels Mar 3, 2022
@lauren-d lauren-d marked this pull request as draft March 3, 2022 10:33
@lauren-d lauren-d force-pushed the lau-sip2-add-comments-column branch from 439093a to 168787f Compare March 3, 2022 10:42
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Mar 3, 2022
@lauren-d lauren-d force-pushed the lau-sip2-add-comments-column branch 3 times, most recently from 811b0c5 to 659517b Compare March 3, 2022 11:20
@lauren-d lauren-d mentioned this pull request Mar 3, 2022
Closed
@lauren-d
selfcheck: add column for comments
9e4b45a 
* Adds a new column in the selfcheck terminals table.
* Updates selfcheck CLI.

Data Migration Instructions:

* run alembic script `b90f8b148948_add_column_to_selfcheck_terminals`.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-sip2-add-comments-column branch from 659517b to 9e4b45a Compare March 3, 2022 11:33
@lauren-d lauren-d marked this pull request as ready for review March 3, 2022 20:33
jma
jma approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks.

@lauren-d lauren-d merged commit c6e9f75 into rero:staging Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@rerowep rerowep rerowep approved these changes

Assignees

@lauren-d lauren-d

Labels
dev: DB Database structure (models.py) enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lauren-d @jma @zannkukai @benerken @rerowep