Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: fix get_all_pids #2614

Merged
merged 1 commit into from
Dec 21, 2021
Merged

modules: fix get_all_pids #2614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rero_ils/modules/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,10 @@ def get_all_pids(cls, with_deleted=False, limit=100000):
"""Get all records pids. Return a generator iterator."""
query = cls._get_all(with_deleted=with_deleted)
if limit:
count = query.count()
# slower, less memory
query = query.order_by(text('pid_value')).limit(limit)
offset = 0
count = cls.count(with_deleted=with_deleted)
while offset < count:
for identifier in query.offset(offset):
yield identifier.pid_value
Expand Down
2 changes: 1 addition & 1 deletion rero_ils/modules/monitoring/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@ def get_all_pids(cls, doc_type, with_deleted=False, limit=100000,
if date:
query = query.filter(PersistentIdentifier.created < date)
if limit:
count = query.count()
# slower, less memory
query = query.order_by(text('pid_value')).limit(limit)
offset = 0
count = query.count()
while offset < count:
for identifier in query.offset(offset):
yield identifier.pid_value
Expand Down