loans: dumping related circulation policy #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-dump-loan-cipo
branch
from
ac31f69 to
1911b7b
Compare
BadrAly
suggested changes
Dec 9, 2021
There was a problem hiding this comment.
I should also note that this circulation policy is not, all the time, the policy used for the loan.
If after a checkout, the item has changed its itty, temp_itty or loc then the api will return a new circ policy which is not really the one used for the loan. same applies if patron changes its ptty.
so this api is most of the time correct except the two cases above.
future enhancement: would be nice to have the used circ_policy at the time of the checkout inside the loan object.
zannkukai
force-pushed
the
zan-dump-loan-cipo
branch
from
1911b7b to
5ecc121
Compare
zannkukai
force-pushed
the
zan-dump-loan-cipo
branch
from
5ecc121 to
7241250
Compare
7 tasks
BadrAly
approved these changes
Dec 9, 2021
Creates an API endpoint to allow dumping the circulation policies informations related to a loan. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-dump-loan-cipo
branch
from
7241250 to
2782775
Compare
benerken
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an API endpoint to allow dumping the circulation
policies informations related to a loan.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list