Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: find and replace identifiedBy #2518

Merged
merged 1 commit into from
Nov 23, 2021
Merged

documents: find and replace identifiedBy #2518

merged 1 commit into from
Nov 23, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Nov 11, 2021

  • Searches and replaces contribution identifiedBy values with $refs.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Nov 11, 2021
@github-actions github-actions bot added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version developers From a developer point of view. f: search labels Nov 11, 2021
@rerowep rerowep force-pushed the wep-#2327-task-search-new-records-for-identified-by-values branch 4 times, most recently from 38c76c1 to 5efbccf Compare November 11, 2021 22:23
zannkukai
zannkukai approved these changes Nov 12, 2021
View reviewed changes
rero_ils/modules/documents/tasks.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-#2327-task-search-new-records-for-identified-by-values branch from 5efbccf to a038653 Compare November 15, 2021 07:37
@rerowep
documents: find and replace identifiedBy
e8d753b 
* Searches and replaces contribution identifiedBy values with $refs.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#2327-task-search-new-records-for-identified-by-values branch from a038653 to e8d753b Compare November 18, 2021 15:06
@rerowep rerowep requested review from vgranata and removed request for iGormilhit November 22, 2021 08:55
@rerowep rerowep merged commit 2b4ec8c into rero:staging Nov 23, 2021
@rerowep rerowep deleted the wep-#2327-task-search-new-records-for-identified-by-values branch November 23, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@rerowep rerowep

Labels
developers From a developer point of view. f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerowep @zannkukai @BadrAly