Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

holdings: fix serial item deletion in ES #2453

Merged
merged 1 commit into from
Oct 13, 2021
Merged

holdings: fix serial item deletion in ES #2453

merged 1 commit into from
Oct 13, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Oct 13, 2021

  • Fixes deletion of items in ES for serial holdings.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep added this to the v1.6.0 milestone Oct 13, 2021
@rerowep rerowep self-assigned this Oct 13, 2021
@rerowep rerowep requested a review from BadrAly October 13, 2021 07:51
@rerowep rerowep force-pushed the wep-fix-holding-items-deletion branch from 7a16384 to f144e7c Compare October 13, 2021 07:51
BadrAly
BadrAly suggested changes Oct 13, 2021
View reviewed changes
rero_ils/modules/holdings/api.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-fix-holding-items-deletion branch from f144e7c to 2872723 Compare October 13, 2021 08:17
@rerowep rerowep requested a review from BadrAly October 13, 2021 08:17
iGormilhit
iGormilhit suggested changes Oct 13, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

holdings: fix serial item deletion in ES

* Fixes deletion of items in ES for serial holdings.

@iGormilhit iGormilhit changed the title holding: Fix delete serial items in ES. holdings: fix serial item deletion in ES Oct 13, 2021
@rerowep rerowep force-pushed the wep-fix-holding-items-deletion branch from 2872723 to dc3de77 Compare October 13, 2021 09:35
@rerowep
holdings: fix serial item deletion in ES
20820d6 
* Fixes deletion of items in ES for serial holdings.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-holding-items-deletion branch from dc3de77 to 20820d6 Compare October 13, 2021 09:40
@iGormilhit iGormilhit added f: serials bug Breaks something but is not blocking labels Oct 13, 2021
@rerowep rerowep merged commit 5046dad into rero:staging Oct 13, 2021
@rerowep rerowep deleted the wep-fix-holding-items-deletion branch October 19, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@jma jma Awaiting requested review from jma

Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking f: serials
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @iGormilhit @zannkukai @BadrAly