Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: add identifiedBy subfield on some fields #2428

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Sep 30, 2021

Co-Authored-by: Bertrand Zuchuat [email protected]

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version f: search labels Sep 30, 2021
@iGormilhit iGormilhit changed the title document: add identifiedBy in relation and series statement documents: add identifiedBy in relation and series statement Oct 5, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title: document:documents:.

@Garfield-fr Garfield-fr force-pushed the zub-document-add-fields branch from 1f13484 to 98d6401 Compare October 5, 2021 06:48
@Garfield-fr Garfield-fr requested a review from iGormilhit October 5, 2021 06:49
@Garfield-fr Garfield-fr force-pushed the zub-document-add-fields branch from 98d6401 to 3753c73 Compare October 6, 2021 11:35
@Garfield-fr Garfield-fr changed the title documents: add identifiedBy in relation and series statement documents: add identifiedBy subfield on some fields Oct 6, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

* Adds `identifiedBy` on relationships, series statement and work access point fields.
* Closes rero#2275.
* Closes rero#2388.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr force-pushed the zub-document-add-fields branch from 3753c73 to 587d5ff Compare October 6, 2021 12:31
@iGormilhit iGormilhit added this to the v1.6.0 milestone Oct 11, 2021
@iGormilhit iGormilhit changed the base branch from dev to staging October 12, 2021 05:36
@JoelleDosimont
Copy link
Contributor

@Garfield-fr
Copy link
Contributor Author

* [ ]  [not bloking] If possible, in the Document in relation and Series statement ([Add identifiers fields for Document in relation (when label) and Series statement #2275](https://github.com/rero/rero-ils/issues/2275)), the identifiers by default can be set on ISSN. I don't know if is possible, as the default in the document is ISBN ?

This is not possible, because the configuration is global to all fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search
Projects
None yet
6 participants