-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documents: add identifiedBy subfield on some fields #2428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
approved these changes
Sep 30, 2021
jma
approved these changes
Oct 4, 2021
iGormilhit
reviewed
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message title: document:
→ documents:
.
1f13484
to
98d6401
Compare
98d6401
to
3753c73
Compare
iGormilhit
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message approved.
* Adds `identifiedBy` on relationships, series statement and work access point fields. * Closes rero#2275. * Closes rero#2388. Co-Authored-by: Bertrand Zuchuat <[email protected]>
3753c73
to
587d5ff
Compare
benerken
approved these changes
Oct 8, 2021
|
This is not possible, because the configuration is global to all fields. |
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: data migration
Data migration from a legacy system or a previous version
f: data
About data model, importation, transformation, exportation of data, specific for bibliographic data
f: search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identifiedBy
on relationships, series statement and work access point fields.Co-Authored-by: Bertrand Zuchuat [email protected]
Code review check list