notification: fix loan notification candidates #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: circulation
Garfield-fr
approved these changes
Sep 28, 2021
BadrAly
approved these changes
Sep 28, 2021
iGormilhit
changed the title
jma
approved these changes
Sep 28, 2021
iGormilhit
approved these changes
Sep 28, 2021
When we check about notification candidates on a loan, we need to exclude the current loan from the current request list on the related item. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-loan-plasters
branch
from
8a701d3 to
f9fc093
Compare
rerowep
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we check about notification candidates on a loan, we need to
exclude the current loan from the current request list on the related
item.
Co-Authored-by: Renaud Michotte [email protected]
Code review check list