Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: create documents with item CLI #2371

Merged
merged 1 commit into from
Sep 23, 2021
Merged

documents: create documents with item CLI #2371

merged 1 commit into from
Sep 23, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Sep 7, 2021

  • Adds a cli for creation of documents with assoziated items.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Sep 7, 2021
@rerowep rerowep marked this pull request as draft September 7, 2021 17:46
@rerowep rerowep force-pushed the wep-#2261-cli-documents-with-items-creation branch 5 times, most recently from 384dc2f to 2442c23 Compare September 8, 2021 12:29
@rerowep rerowep marked this pull request as ready for review September 8, 2021 20:15
@rerowep rerowep marked this pull request as draft September 9, 2021 15:15
@rerowep rerowep force-pushed the wep-#2261-cli-documents-with-items-creation branch 5 times, most recently from 4f01281 to 593a9d2 Compare September 14, 2021 14:48
@rerowep rerowep added this to the v1.5.0 milestone Sep 17, 2021
@rerowep rerowep marked this pull request as ready for review September 21, 2021 08:13
@iGormilhit iGormilhit changed the base branch from dev to v1.5.0 September 21, 2021 08:24
iGormilhit
iGormilhit suggested changes Sep 21, 2021
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

documents: create documents with item CLI

* Extends item CLI for validating and creating documents with linked
  items.

rero_ils/modules/cli.py Outdated Show resolved Hide resolved
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
rero_ils/modules/cli.py Outdated Show resolved Hide resolved
@rerowep
documents: create documents with item CLI
578b73e 
* Extends item CLI for validating and creating documents with linked
  items.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#2261-cli-documents-with-items-creation branch from 593a9d2 to 578b73e Compare September 21, 2021 08:36
@rerowep rerowep requested a review from iGormilhit September 21, 2021 08:38
@iGormilhit iGormilhit changed the title documents: documents with item cli documents: create documents with item CLI Sep 22, 2021
@rerowep rerowep merged commit 60622d2 into rero:v1.5.0 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@benerken benerken benerken approved these changes

@BadrAly BadrAly BadrAly approved these changes

@jma jma Awaiting requested review from jma

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @iGormilhit @zannkukai @benerken @BadrAly