release: v1.4.9 #2365
Merged
release: v1.4.9 #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dev: documentation
mmo
reviewed
Sep 3, 2021
RELEASE-NOTES.rst
Outdated
| This patch brings many improvements and fixes on the notification | ||
| process, such as: | ||
|
|
||
| - Preventing to send (again and again) notifications that are in an |
There was a problem hiding this comment.
Suggested change
| - Preventing to send (again and again) notifications that are in an | |
| - Preventing to repeatedly send notifications that are in an |
RELEASE-NOTES.rst
Outdated
|
|
||
| - Preventing to send (again and again) notifications that are in an | ||
| error state. | ||
| - Preventing notification to be in an error state if the pickup |
There was a problem hiding this comment.
Suggested change
| - Preventing notification to be in an error state if the pickup | |
| - Preventing notifications to be in an error state if the pickup |
RELEASE-NOTES.rst
Outdated
| - Preventing notification to be in an error state if the pickup | ||
| location is deleted. | ||
| - Cancelling generated notifications if the situation changed between | ||
| the generation and the processing. In deed, some notifications are |
There was a problem hiding this comment.
Suggested change
| the generation and the processing. In deed, some notifications are | |
| the generation and the processing. Indeed, some notifications are |
RELEASE-NOTES.rst
Outdated
| - Cancelling generated notifications if the situation changed between | ||
| the generation and the processing. In deed, some notifications are | ||
| asynchronous in order to be able to group several notifications of | ||
| the same type to the same patron. But in that delay, the notification |
There was a problem hiding this comment.
Suggested change
| the same type to the same patron. But in that delay, the notification | |
| the same type to the same patron. But in the meantime, a notification |
RELEASE-NOTES.rst
Outdated
| - Preventing to send reminders if the library is closed between the due | ||
| date and the notification processing (`#2303`_). | ||
| - Computing the date at which the due soon notification has to be sent when | ||
| creating the loan, instead of through a recurring task, in order to |
There was a problem hiding this comment.
Suggested change
| creating the loan, instead of through a recurring task, in order to | |
| creating the loan, instead of through a recurring task, in order to improve |
RELEASE-NOTES.rst
Outdated
| date and the notification processing (`#2303`_). | ||
| - Computing the date at which the due soon notification has to be sent when | ||
| creating the loan, instead of through a recurring task, in order to | ||
| performance and get a more stable date. |
There was a problem hiding this comment.
Suggested change
| performance and get a more stable date. | |
| performance and apply a more stable date. |
RELEASE-NOTES.rst
Outdated
| - Computing the date at which the due soon notification has to be sent when | ||
| creating the loan, instead of through a recurring task, in order to | ||
| performance and get a more stable date. | ||
| - Processing the due soon and overdue notification as soon as possible, to |
There was a problem hiding this comment.
Suggested change
| - Processing the due soon and overdue notification as soon as possible, to | |
| - Processing due soon and overdue notifications as soon as possible, to |
mmo
reviewed
Sep 3, 2021
RELEASE-NOTES.rst
Outdated
Comment on lines
24
to
25
| This patch brings many improvements and fixes on the notification | ||
| process, such as: |
There was a problem hiding this comment.
Suggested change
| This patch brings many improvements and fixes on the notification | |
| process, such as: | |
| This patch brings several improvements and fixes on the notification | |
| process: |
jma
approved these changes
Sep 4, 2021
Co-Authored-by: Igor Milhit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Igor Milhit [email protected]
Why are you opening this PR?
v1.4.9release.How to test?
Code review check list