Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: fix overdue without library open days #2349

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Sep 1, 2021

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Sep 1, 2021
* Does not send overdue notification if the library is closed between
  the end date and the processing date.
* Closes: rero#2303.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-reminders branch from b5098e3 to a089f82 Compare September 1, 2021 14:30
@jma jma marked this pull request as ready for review September 1, 2021 14:30
@jma jma changed the title notifications: fix overdue with no lib open days notifications: fix overdue without library open days Sep 1, 2021
@jma jma added this to the v1.4.9 milestone Sep 1, 2021
@iGormilhit iGormilhit merged commit 67883b9 into rero:dev Sep 2, 2021
@jma jma deleted the maj-fix-reminders branch January 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reminders notifications are not generated correctly
5 participants