documents: optimize serialization #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
requested review from
zannkukai,
jma,
rerowep,
iGormilhit and
sebdeleze
Garfield-fr
force-pushed
the
zub-document-serializer-optimisation
branch
2 times, most recently
from
d76761c to
e3cdc2a
Compare
rerowep
requested changes
Aug 18, 2021
Garfield-fr
force-pushed
the
zub-document-serializer-optimisation
branch
2 times, most recently
from
ac77547 to
885518f
Compare
Garfield-fr
force-pushed
the
zub-document-serializer-optimisation
branch
from
885518f to
f298200
Compare
Garfield-fr
changed the title
zannkukai
reviewed
Aug 19, 2021
zannkukai
reviewed
Aug 19, 2021
zannkukai
approved these changes
Aug 19, 2021
Garfield-fr
force-pushed
the
zub-document-serializer-optimisation
branch
from
f298200 to
07d3035
Compare
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
zub-document-serializer-optimisation
branch
from
07d3035 to
325bab7
Compare
rerowep
approved these changes
Aug 19, 2021
sebdeleze
approved these changes
Aug 20, 2021
iGormilhit
reviewed
Sep 2, 2021
| if fields: | ||
| query = query.source(includes=fields) | ||
| response = query.execute() | ||
| if response.hits.total.value != 1: |
There was a problem hiding this comment.
What if they are two or more hits? Should the message be something like " 😱 "?
There was a problem hiding this comment.
A pid value is unique. Either it exists or you have an exception?
iGormilhit
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat [email protected]
How to test?
Code review check list