Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sip2: improve selfcheck checkout #2274

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Aug 6, 2021

  • Checks if item is already checked out or requested
  • Adds screen message on checkout error.
  • Bumps invenio-sip2 to v0.6.10.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d self-assigned this Aug 6, 2021
@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Aug 6, 2021
@lauren-d lauren-d marked this pull request as draft August 6, 2021 10:28
@lauren-d lauren-d force-pushed the lau-sip2-improve-checkout branch from 003eb09 to b9a0849 Compare August 9, 2021 09:35
@lauren-d lauren-d marked this pull request as ready for review August 9, 2021 09:36
@lauren-d lauren-d requested review from jma, benerken and BadrAly August 9, 2021 09:37
* Checks if item is already checked out or requested
* Adds screen message on checkout error.
* Bumps invenio-sip2 to v0.6.10.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-sip2-improve-checkout branch from b9a0849 to 22c784f Compare August 9, 2021 13:42
@jma jma merged commit e3eca6c into rero:dev Aug 12, 2021
@lauren-d lauren-d deleted the lau-sip2-improve-checkout branch September 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants