Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: fix patron with additional email #2220

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Jul 21, 2021

Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Bertrand Zuchuat [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma jma force-pushed the maj-fix-patron-add-email-notif branch from c7fc8b4 to 3bf83bf Compare July 21, 2021 10:01
@github-actions github-actions bot added the dev: fixtures Fixtures data used for ils.test and ilsdev.test label Jul 21, 2021
@jma jma requested review from rerowep, BadrAly and iGormilhit July 21, 2021 10:04
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit added this to the v1.4.6 milestone Jul 21, 2021
* Sends the notification to the patron additional email if exists
  instead of the library.
* Closes rero#2152.
* Adapts the fixtures to have a user with an additional email only.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@jma jma force-pushed the maj-fix-patron-add-email-notif branch from 3bf83bf to effc934 Compare July 21, 2021 10:57
@jma jma merged commit 417754b into rero:dev Jul 21, 2021
@jma jma deleted the maj-fix-patron-add-email-notif branch January 13, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: fixtures Fixtures data used for ils.test and ilsdev.test f: notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request is sent to the wrong e-mail and even if the document is on loan
5 participants