Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patrons: display user PID in error message #2153

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jul 13, 2021

  • Adds user information for more than one librarian account problem.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Jul 13, 2021
@iGormilhit iGormilhit changed the title patron: display user in error message patrons: display user PID in error message Jul 13, 2021
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

patrons: add user data in error message

* Adds user information for `more than one librarian account` problem.

@rerowep rerowep force-pushed the wep-patron-multiple-roles branch from 13671b4 to c055b04 Compare July 14, 2021 07:53
@rerowep rerowep requested a review from iGormilhit July 14, 2021 07:53
* Adds user information for `more than one librarian account` problem.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-patron-multiple-roles branch from c055b04 to 5e7a331 Compare July 14, 2021 12:58
@rerowep rerowep merged commit b45058e into rero:dev Jul 14, 2021
@rerowep rerowep deleted the wep-patron-multiple-roles branch July 19, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants